Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default for max_open_connections for DB plugins to 4 #7093

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Change the default for max_open_connections for DB plugins to 4 #7093

merged 1 commit into from
Jul 18, 2019

Conversation

mjarmy
Copy link
Contributor

@mjarmy mjarmy commented Jul 9, 2019 •
edited
Loading

Change the default for max_open_connections for DB plugins to 4, for all database types.

This PR fixes issue #6790

@mjarmy mjarmy mentioned this pull request Jul 9, 2019
Closed
@mjarmy mjarmy added this to the 1.2 milestone Jul 9, 2019
@mjarmy mjarmy marked this pull request as ready for review July 18, 2019 20:09
@mjarmy mjarmy changed the title [DRAFT] Change the default for max_open_connections for DB plugins to 4 Change the default for max_open_connections for DB plugins to 4 Jul 18, 2019
@mjarmy mjarmy requested a review from jefferai July 18, 2019 20:10
@mjarmy mjarmy self-assigned this Jul 18, 2019
jefferai
jefferai approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- please add something to the CHANGES section as well as the normal improvements section bit once it's merged.

@mjarmy mjarmy merged commit 60e2120 into master Jul 18, 2019
@jefferai jefferai deleted the change-db-max-connection-default branch July 19, 2019 13:40
@spangenberg spangenberg mentioned this pull request Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees

@mjarmy mjarmy

Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mjarmy @jefferai