UI - add kmip engine #6936

meirish · 2019-06-20T17:37:35Z

This adds the ability to create Scopes, Roles, and Credentials using the Vault Enterprise KMIP Secrets Engine, as well as enabling and configuring it.

Currently you can't delete any of these items - that and tests will come in a follow up PR.

andaley · 2019-06-20T23:41:55Z

ui/app/helpers/mountable-secret-engines.js

+  category: 'generic',
+};
+
+export const MOUNTABLE_SECRET_ENGINES = [


pretty sure we don't need to export this const anymore since we're only using the KMIP const elsewhere

andaley · 2019-06-21T00:18:38Z

ui/lib/core/addon/components/field-group-show.js

+ *
+ * @example
+ * ```js
+ * <FieldGroupShow @param1={param1} @param2={param2} />


We should update these docs (and eventually in another PR add to Storybook). 😬

Yeah there's lots to add to storybook because we moved a bunch over to core.

andaley · 2019-06-21T00:40:02Z

ui/lib/core/addon/templates/components/field-group-show.hbs

+        {{#each fields as |attr|}}
+          <InfoTableRow
+            @alwaysRender={{showAllFields}}
+            @label={{capitalize (or attr.options.label (humanize (dasherize attr.name)))}}


I think we may no longer need to do both humanize and dasherize since openApi gives us displayNames now, but we could also leave this in here just in case there are new fields that don't have them. 🤔

It's the fallback here - that's what the or is doing - so I think it's worth keeping. attr.options.label gets populated from Open API's display name struct.

johncowen

I noticed a couple of tiny things, one of which is just a question for me.

Overall I noticed there seems to be a move away from conventional ember practices (there are a lot of things here like transition-to and set-flash-message helpers, that would usually be done out of a template). Me personally, I prefer everything just being a well defined component and/or a helper (basically a JS function), makes everything far easier to work with.

P.S. I only didn't approve as you have @noelledaley here already.

johncowen · 2019-06-20T18:18:46Z

ui/app/adapters/kmip/base.js

+import ApplicationAdapater from '../application';
+import { encodePath } from 'vault/utils/path-encoding-helpers';
+
+export default ApplicationAdapater.extend({


Typo 👮 ! Adapater > Adapter

Lol nice catch - I do that particular one way too often. At least they match so it's not broken 😛 - I'll get that fixed though!

Hehehe nice, yeah I've done the matching typo thing waaaaay too many times

johncowen · 2019-06-21T12:10:31Z

ui/lib/kmip/addon/templates/components/header-credentials.hbs

+        {{#link-to "role" @scope @role}}
+          Details
+        {{/link-to}}
+      {{/link-to}}


If you have time, could you walk me through what is happening here? (re: the nested link-tos)

So this is a sad thing we do because we were trying to use as much of bulma's CSS as we could initially. We'll get rid of this when we have our own tabs component.

But what's it's doing is constructing <li><a/></li> for the tab - tagName on the outer one is the important thing here. If I'm remembering correctly we needed to do this because bulma styles active tabs on the li, so we're using link-to's ability to get the active class when the route matches.

meirish · 2019-06-21T15:01:51Z

Hey @johncowen thanks for looking at this!

Overall I noticed there seems to be a move away from conventional ember practices (there are a lot of things here like transition-to and set-flash-message helpers, that would usually be done out of a template). Me personally, I prefer everything just being a well defined component and/or a helper (basically a JS function), makes everything far easier to work with.

Yeah I think closure actions opened up a lot of possibilities here and gives the flexibility of passing in things from above (from a component or controller) or via a helper that uses a service (which is what both transition-to and set-flash-message do). I've found I'm looking for helpers more as we're building out more reusable components because it feels like things compose more easily.

…mports

…ntials

…rogrammatically inside an engine

johncowen · 2019-06-21T16:44:56Z

Cool thanks for the extra info @meirish. +1 to the helpers thing, I definitely find myself reaching for helpers more (when I can) instead of Controller/computedProperties

madalynrose · 2019-06-21T15:37:23Z

ui/app/models/kmip/config.js

+    return `/v1/${path}/config?help=1`;
+  },
+
+  listenAddrs: attr({


shouldn't need this with the new OpenAPI changes

… into ui-add-kmip-engine

* master: (47 commits) Add the ability to use a dev Consul node for dev storage (#6965) Update CHANGELOG.md Correct API docs examples (#6963) Fix test changelog++ Allow turning on client auth in test clusters (#6958) Update vendoring Update SDK version Make CA certificate optional in ClientTLSConfig Update vendor Combined Database backend: remove create/delete support (#6951) Bump sdk Move tls config creation to tlsutil (#6956) Update JWT tips (#6955) raft join tls (#6932) changelog++ UI - add kmip engine (#6936) Pass context to Cassandra queries (#6954) Minor clean up JWT provider docs (#6952) update azure instructions (#6858) ...

meirish added this to the 1.2 milestone Jun 20, 2019

meirish requested review from a team June 20, 2019 17:47

andaley reviewed Jun 20, 2019

View reviewed changes

andaley reviewed Jun 21, 2019

View reviewed changes

johncowen reviewed Jun 21, 2019

View reviewed changes

meirish and others added 22 commits June 21, 2019 10:23

add kmip engine

1e1383b

adjust where kmip engine is mounted and sketch out routes

eb0676d

add secret mount path service to share params to engines

4190cc4

move list-controller and list-route mixins to core addon and adjust i…

667c0e3

…mports

properly link kmip secrets from the secrets list page

ed0e0a5

tweak routes and add list controllers

4087c8d

stub out some models and adapters

4446348

fix mixin exports

4d87cb9

move a bunch of components into the core addon

587b18c

use new empty yield in list-view in the namespace template

c86d883

scopes list using list-view and list-item components

eb6c5b8

simplify and flatten routes, templates for all of the list pages

7588fab

role show route and template and scope create template

77a48a9

add ember-router-helpers

f8a9435

add more packages to the dependencies of the core addon

3d02ccc

add field-group-show component for listing fields from a model

e523999

move more components to the shared addon

1dbfbc8

make configure and configuration routes work and save a generated model

dbd483a

save and list scopes

5e1fe87

role create, list, read

030edf4

list credentials properly

a32f842

move allowed attributes to field group

c6c9dce

meirish and others added 13 commits June 21, 2019 10:27

credential create and show

b37d1a3

only show kmip when feature is enabled

a5dda33

fix saving of TTL fields generated from Open API

efab2ef

move masked-input and list-pagination components to core addon

eecf944

add param on edit form to allow for calling onSave after render happens

65c03ca

polish credential show page and redirect there after generating crede…

790e4c7

…ntials

add externalLink for kmip engine

09ecc02

add kmip-breadcrumb component

7a36839

use kmip-breadcrumb component

58ca5fe

add linkPrefix param to linked-block component to allow for routing p…

6ac4db9

…rogrammatically inside an engine

redirect to the right place when enabling kmip

fcbb2c9

fix linting

7900bcd

review feedback

f138538

meirish force-pushed the ui-add-kmip-engine branch from 148197a to f138538 Compare June 21, 2019 15:31

update signature for path-help usage

4633c43

madalynrose previously approved these changes Jun 21, 2019

View reviewed changes

fix ttl field expansion test

64bf50a

madalynrose dismissed their stale review via 64bf50a June 21, 2019 18:07

meirish and others added 8 commits June 21, 2019 13:17

remove role filed from role form, fix generate redirect

0aba782

remove field-group-show because it's in the core addon

5defac7

remove bottom rule from show pages

147e771

fix Max TTL displayAttrs for ssh role

09a76b9

Merge branch 'ui-add-kmip-engine' of https://github.com/hashicorp/vault…

679142f

… into ui-add-kmip-engine

update edit-form to take fields or attrs

ae52ec1

fix linting

98272a7

remove listenAddrs and set default val on ttl if a val is passed in

7d2da88

meirish merged commit 7e9c016 into master Jun 21, 2019

meirish deleted the ui-add-kmip-engine branch June 21, 2019 21:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI - add kmip engine #6936

UI - add kmip engine #6936

meirish commented Jun 20, 2019 •

edited

Loading

andaley Jun 20, 2019

andaley Jun 21, 2019

meirish Jun 21, 2019

andaley Jun 21, 2019

meirish Jun 21, 2019

johncowen left a comment •

edited

Loading

johncowen Jun 20, 2019

meirish Jun 21, 2019

johncowen Jun 21, 2019

johncowen Jun 21, 2019

meirish Jun 21, 2019

meirish commented Jun 21, 2019

johncowen commented Jun 21, 2019

madalynrose Jun 21, 2019

UI - add kmip engine #6936

UI - add kmip engine #6936

Conversation

meirish commented Jun 20, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

johncowen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meirish commented Jun 21, 2019

johncowen commented Jun 21, 2019

Choose a reason for hiding this comment

meirish commented Jun 20, 2019 •

edited

Loading

johncowen left a comment •

edited

Loading