Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ember assign polyfill for ie11 #6567

Merged
merged 1 commit into from
Apr 10, 2019
Merged

add ember assign polyfill for ie11 #6567

merged 1 commit into from
Apr 10, 2019

Conversation

andaley
Copy link
Contributor

@andaley andaley commented Apr 10, 2019

This PR replaces the use of Object.assign, which isn't supported by ie11, with the ember assign polyfill. This bug was causing the Vault UI not to render in ie11.

meirish
meirish approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@meirish meirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't realize you could import things from ember in the storybook config either - that's cool ✨

@andaley andaley added this to the 1.1.1 milestone Apr 10, 2019
@andaley andaley merged commit 6db5c65 into master Apr 10, 2019
@jefferai jefferai deleted the ui/add-assign-polyfill branch April 11, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meirish meirish meirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@andaley @meirish