Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uri_sans param being ignored when use_csr_values=false #6505

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Fix uri_sans param being ignored when use_csr_values=false #6505

merged 1 commit into from
Apr 1, 2019

Conversation

mdgreenfield
Copy link
Contributor

fixes #6504

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 29, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jefferai jefferai added this to the 1.1.1 milestone Mar 29, 2019
jefferai
jefferai approved these changes Apr 1, 2019
View reviewed changes
Copy link
Member

@jefferai jefferai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jefferai jefferai merged commit 6b33746 into hashicorp:master Apr 1, 2019
rboyer added a commit to hashicorp/consul that referenced this pull request Sep 16, 2019
@rboyer
connect: intermediate CA certs generated with the vault provider lack…
ab3aa34 
… URI SANs

This only affects vault versions >=1.1.1 because the prior code
accidentally relied upon a bug that was fixed in
hashicorp/vault#6505

The existing tests should have caught this, but they were using a
vendored copy of vault version 0.10.3. This fixes the tests by running
an actual copy of vault instead of an in-process copy. This has the
added benefit of changing the dependency on vault to just vault/api.

Also update VaultProvider to use similar SetIntermediate validation code
as the ConsulProvider implementation.
@rboyer rboyer mentioned this pull request Sep 16, 2019
Merged
rboyer added a commit to hashicorp/consul that referenced this pull request Sep 18, 2019
@rboyer
connect: intermediate CA certs generated with the vault provider lack…
3c11e17 
… URI SANs

This only affects vault versions >=1.1.1 because the prior code
accidentally relied upon a bug that was fixed in
hashicorp/vault#6505

The existing tests should have caught this, but they were using a
vendored copy of vault version 0.10.3. This fixes the tests by running
an actual copy of vault instead of an in-process copy. This has the
added benefit of changing the dependency on vault to just vault/api.

Also update VaultProvider to use similar SetIntermediate validation code
as the ConsulProvider implementation.
rboyer added a commit to hashicorp/consul that referenced this pull request Sep 23, 2019
@rboyer
connect: intermediate CA certs generated with the vault provider lack…
07db581 
… URI SANs

This only affects vault versions >=1.1.1 because the prior code
accidentally relied upon a bug that was fixed in
hashicorp/vault#6505

The existing tests should have caught this, but they were using a
vendored copy of vault version 0.10.3. This fixes the tests by running
an actual copy of vault instead of an in-process copy. This has the
added benefit of changing the dependency on vault to just vault/api.

Also update VaultProvider to use similar SetIntermediate validation code
as the ConsulProvider implementation.
rboyer added a commit to hashicorp/consul that referenced this pull request Sep 23, 2019
@rboyer
connect: intermediate CA certs generated with the vault provider lack…
796de29 
… URI SANs (#6491)

This only affects vault versions >=1.1.1 because the prior code
accidentally relied upon a bug that was fixed in
hashicorp/vault#6505

The existing tests should have caught this, but they were using a
vendored copy of vault version 0.10.3. This fixes the tests by running
an actual copy of vault instead of an in-process copy. This has the
added benefit of changing the dependency on vault to just vault/api.

Also update VaultProvider to use similar SetIntermediate validation code
as the ConsulProvider implementation.
rboyer added a commit to hashicorp/consul that referenced this pull request Sep 23, 2019
@rboyer
connect: intermediate CA certs generated with the vault provider lack…
39e4fee 
… URI SANs (#6491)

This only affects vault versions >=1.1.1 because the prior code
accidentally relied upon a bug that was fixed in
hashicorp/vault#6505

The existing tests should have caught this, but they were using a
vendored copy of vault version 0.10.3. This fixes the tests by running
an actual copy of vault instead of an in-process copy. This has the
added benefit of changing the dependency on vault to just vault/api.

Also update VaultProvider to use similar SetIntermediate validation code
as the ConsulProvider implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefferai jefferai jefferai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.

CSR Signing: uri_sans param ignored when use_csr_values=false
3 participants
@mdgreenfield @hashicorp-cla @jefferai