Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TypeCommaStringSlice for SSH zeroaddress roles #5528

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Use TypeCommaStringSlice for SSH zeroaddress roles #5528

merged 1 commit into from
Oct 17, 2018

Conversation

jefferai
Copy link
Member

Fixes #5527

@jefferai jefferai added this to the 0.12 milestone Oct 16, 2018
@briankassouf briankassouf merged commit 13d8f7b into master Oct 17, 2018
@briankassouf briankassouf deleted the issue-5527 branch October 17, 2018 06:33
@roooms
Copy link
Contributor

roooms commented Oct 17, 2018

Dow's this mean the docs are right to propose a list with [] or should it still be a comma separated ”list” (a string) without []?

@chrishoffman
Copy link
Contributor

@roooms Our docs are not consistent here, but usually for the API we show the native type (list in this case) and the CLI docs we say something like "list or comma separated string".

@jefferai jefferai modified the milestones: 0.12, 0.11.4 Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jefferai @roooms @chrishoffman @briankassouf