UI - disable JSON toggle when data is not only strings #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meirish
commented
Jul 12, 2018
| class="switch is-rounded is-success is-small" | ||
| checked={{showAdvancedMode}} | ||
| onchange={{action "toggleAdvanced" value="target.checked"}} | ||
| disabled={{and (eq mode 'show') secretDataIsAdvanced}} |
There was a problem hiding this comment.
This line is the only code change - just formatted the input for easier reading.
DingoEatingFuzz
previously approved these changes
Jul 12, 2018
|
Not one, but two tests! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The UI much like the CLI assumes all input for secrets are strings when you're in the default editing mode. If you input raw JSON into either, you can get more data types (numbers, arrays, null - anything that's valid as a JSON value), and when this happens - the UI disables the default mode.
Previously, you'd be able to use the toggle, but it wouldn't do anything. Also disabling the toggle makes it more clear that this is the intended behavior.
Fixes #4912