UI identity lists #4655
Merged
UI identity lists #4655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed the side padding on the tabs so the spacing is nicer. |
joshuaogle
reviewed
May 30, 2018
| {{#if item.aliases.length}} | ||
| {{pluralize item.aliases.length "alias"}} | ||
| {{/if}} | ||
| {{else}} |
There was a problem hiding this comment.
Oh left that in from groups, can take out the outer if entirely until we land other groups stuff.
| <div class="has-text-grey"> | ||
| {{item.id}} | ||
| </div> | ||
| <span class="tag"> {{item.mountType}} </span> |
There was a problem hiding this comment.
Did this need spaces between for a reason?
There was a problem hiding this comment.
Lol nope, was being hasty - will fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new
key_infoblock on identity list endpoints to make the Identity UI (Access > Entities and Access > Groups) nicer to navigate and reason about. Groups now also show a "Parent Groups" tab that lists the groups a group is a member of.Also makes a visual adjustment to the tabs subnav to be closer to the designs.