Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad: updating max token length to 256 #4361

Closed

Conversation

burdandrei
Copy link
Contributor

as it's updated in Nomad 0.8
hashicorp/nomad#3888

@jefferai
Copy link
Member

I'm not sure we want to do this yet since most people won't be running Nomad 0.8 for a while.

@jefferai jefferai added this to the 0.11 milestone Apr 15, 2018
@burdandrei
Copy link
Contributor Author

@jefferai you're right, just leave it here for the future =)

@jippi
Copy link
Contributor

jippi commented Apr 15, 2018

they will pretty soon though, like in the next few weeks :)

@jefferai
Copy link
Member

I'm targeting this for 0.11 in a few months. But we might need this to be a tunable to merge it, will have to see if the Nomad team has guidance.

@burdandrei
Copy link
Contributor Author

if you want I can add the configuration option with the target nomad version

@jippi
Copy link
Contributor

jippi commented Apr 16, 2018

does it matter? isn't it just truncating a key - so if you pass in 64 (nomad <.0.8) it just won't truncate?

@jefferai
Copy link
Member

Yeah, rather than target Nomad version you'd want to just specify a max length, which can default to 64. At some point we can switch that to default to 256.

@burdandrei
Copy link
Contributor Author

I think normal operator doesn't have to know there are those limits, like MySQL plugin(legacy, rds, Maria)

@jefferai
Copy link
Member

If a normal operator isn't going to touch the settings, it doesn't matter whether they accept a default of "Nomad <0.8" or "64".

Copy link
Contributor

@kalafut kalafut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor comments.

chrishoffman pushed a commit that referenced this pull request Aug 16, 2018
…5117)

* Nomad: updating max token length to 256

* Initial support for supporting custom max token name length for Nomad

* simplify/correct tests

* document nomad max_token_name_length

* removed support for max token length env var. Rename field for clarity

* cleanups after removing env var support

* move RandomWithPrefix to testhelpers

* fix spelling

* Remove default 256 value. Use zero as a sentinel value and ignore it

* update docs
@chrishoffman
Copy link
Contributor

Fixed in #5117

JanMa pushed a commit to JanMa/openbao-plugin-secrets-nomad that referenced this pull request Jan 28, 2024
…p/vault#4361] (#5117)

* Nomad: updating max token length to 256

* Initial support for supporting custom max token name length for Nomad

* simplify/correct tests

* document nomad max_token_name_length

* removed support for max token length env var. Rename field for clarity

* cleanups after removing env var support

* move RandomWithPrefix to testhelpers

* fix spelling

* Remove default 256 value. Use zero as a sentinel value and ignore it

* update docs
JanMa pushed a commit to JanMa/openbao-plugin-secrets-nomad that referenced this pull request Jan 28, 2024
…p/vault#4361] (#5117)

* Nomad: updating max token length to 256

* Initial support for supporting custom max token name length for Nomad

* simplify/correct tests

* document nomad max_token_name_length

* removed support for max token length env var. Rename field for clarity

* cleanups after removing env var support

* move RandomWithPrefix to testhelpers

* fix spelling

* Remove default 256 value. Use zero as a sentinel value and ignore it

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants