Config parameter "tls_disable_client_certs" is wrongly evaluated. #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LD_FLAGS can be used as environment variable
Merge latest changes to master
jefferai
reviewed
Feb 28, 2018
command/server/listener.go
Outdated
| if disableClientCerts { | ||
| tlsConf.ClientAuth = tls.NoClientCert | ||
| } | ||
| if !disableClientCerts { |
There was a problem hiding this comment.
This if section shouldn't be here. Only the first is needed.
There was a problem hiding this comment.
If "tls_disable_client_certs" is set to false, then if client provides a certificate shouldn't it be validated.
There was a problem hiding this comment.
Sorry I overlooked the default value set.
…ts is set to true.
jefferai
approved these changes
Feb 28, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config parameter "tls_disable_client_certs" is evaluated wrongly, i.e. irrespective of the value set the action taken is that of when set to true.