auth/cert: Remove looped DNSName checking as Go 1.10 covers it already #4010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
:-( |
chrishoffman
pushed a commit
that referenced
this pull request
Feb 21, 2018
* oss/master: (178 commits) Cut version 0.9.4 Remove netbsd/arm as it won't compile Bump files for new version Update plugins Update go-plugin changelog++ Handling nomad maxTokenNameLength = 64 (#4009) Remove unneeded looping since Go 1.10 cover it already (#4010) Fix test statement with formatting in fatal call Fix PKI tests by generating on-demand Sanitize pem encoding to Go default of a newline at the end rather than break backwards compat Remove now-unneeded PKCS8 code and update certutil tests for Go 1.10 Kick Travis Bump Travis to Go 1.10 Fix bug with vault cli when reading an individual field containing a Printf formatting verb (#4005) Adding path roles test coverage for storing PKIX fields (#4003) Add test coverage for recently-added PKIX fields. (#4002) Fix missing CommonName in subject generation changelog++ Handle missed error case in seal status output format (#4001) ...
chrishoffman
pushed a commit
that referenced
this pull request
Feb 23, 2018
* oss/master: (35 commits) helper/gpgkeys: fix for vault 1.10 (#4038) Move local cluster parameters to atomic values to fix some potential data races (#4036) Port some replicated cluster changes from ent (#4037) Add core object to policy store for some ent uses changelog++ Configurable Consul Service Address (#3971) Fix certutil test Fixed a broken link (#4032) Update comment to replication consts Add a helpful comment to replication consts changelog++ auth/aws: Add functional test for detached RSA signature (#4031) Change Go min version check changelog++ Revert Go dep to 1.9 *Partially* revert "Remove now-unneeded PKCS8 code and update certutil tests for Go 1.10" Revert "Remove unneeded looping since Go 1.10 cover it already (#4010)" Bump pkcs7 library version to fix #4024 Revert "Switch to a forked copy of pkcs7 to fix aws pkcs7 verification error (#4024)" changelog++ ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestBackend_PermittedDNSDomainsIntermediateCA passes even without looping.