Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused recovery field in DynamoDB backend #3569

Merged
merged 2 commits into from
Nov 13, 2017
Merged

Remove unused recovery field in DynamoDB backend #3569

merged 2 commits into from
Nov 13, 2017

Conversation

ungureanuvladvictor
Copy link
Contributor

Looks like when #2141 was merged the recovery field in the DynamoDBLock and DynamoDBBackend structs was not removed but it is not used anymore.

@ungureanuvladvictor
Copy link
Contributor Author

@jefferai looks like Travis forgot to send back the hook for the failed build. Anyway the build failed because:

ok  	github.com/hashicorp/vault	0.123s [no tests to run]
--- FAIL: TestClientEnvSettings (0.01s)
	client_test.go:167: bad: expected client tls config to have a client certificate
FAIL
FAIL	github.com/hashicorp/vault/api	21.054s

which seems pretty unrelated with my change. https://travis-ci.org/hashicorp/vault/builds/300407400 failed from the same reason as well.

@jefferai
Copy link
Member

Thanks!

@jefferai jefferai added this to the 0.9.0 milestone Nov 13, 2017
@jefferai jefferai merged commit 81f968f into hashicorp:master Nov 13, 2017
@ungureanuvladvictor ungureanuvladvictor deleted the fix/remove-unused-fields branch November 14, 2017 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants