Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the sys/raw endpoint by default #3329

Merged
merged 7 commits into from
Sep 15, 2017
Merged

Conversation

chrishoffman
Copy link
Contributor

Considering the highly sensitive nature of this endpoint and the infrequent usage, disable this endpoint by default and add a config option to enable it.

@jefferai
Copy link
Member

I love everything about it except the name. "raw" seems too vague. Maybe "raw_storage_access"? Otherwise LGTM.

@chrishoffman
Copy link
Contributor Author

I came up with enable_raw, raw_endpoint, and enable_raw_endpoint. I followed the lead of ui and just went with raw. I'll ask a few more people and change it to be more explicit.

@@ -854,7 +854,7 @@ func NewSystemBackend(core *Core) *SystemBackend {

if core.rawEnabled {
b.Backend.Paths = append(b.Backend.Paths, &framework.Path{
Pattern: "raw/(?P<path>.+)",
Pattern: "(raw/?$|raw/(?P<path>.+))",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh fancy

@jefferai jefferai added this to the 0.8.3 milestone Sep 15, 2017
@chrishoffman chrishoffman merged commit 4a8c33c into master Sep 15, 2017
@chrishoffman chrishoffman deleted the raw-endpoint-off branch September 15, 2017 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants