Add 'pid_file' config option #3321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefferai
reviewed
Sep 12, 2017
command/server.go
Outdated
| @@ -50,6 +50,8 @@ import ( | |||
|
|
|||
| // ServerCommand is a Command that starts the Vault server. | |||
| type ServerCommand struct { | |||
| Config *server.Config | |||
There was a problem hiding this comment.
This seems unnecessary, why not just give the path to storePid?
chrishoffman
suggested changes
Sep 13, 2017
|
@chrishoffman I'm now removing it on shutdown. |
chrishoffman
previously approved these changes
Sep 14, 2017
jefferai
reviewed
Sep 15, 2017
command/server.go
Outdated
| } | ||
|
|
||
| // Open the PID file | ||
| pidFile, err := os.OpenFile(pidPath, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0666) |
There was a problem hiding this comment.
These permissions are too open -- certainly the file should not be world-writable. I suggest 0644.
jefferai
reviewed
Sep 15, 2017
| @@ -105,6 +105,9 @@ to specify where the configuration is. | |||
| the standard Vault API address will automatically redirect there. This can also | |||
| be provided via the environment variable `VAULT_UI`. | |||
|
|
|||
| - `pid_file` `(string: "")` - Path to the file in which Vault server PID should | |||
There was a problem hiding this comment.
I'd say "Path to the file in which the Vault server's Process ID (PID) should be stored."
Just in case people think PID is something Vault-y. You never know...
jefferai
requested changes
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.