Add 'Period' support to AWS IAM token renewal #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! The extra TTL handling for the EC2 method is due to the fact that TTLs can be embedded in role tags. I don't think it's necessary here; the framework function will handle ensuring that it can't go above mount/system max limits. |
|
Thanks @jefferai! Yes the framework code appeared to do the same thing but I wasn't 100% sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Period does not appear to be used when renewing a token created against an AWS role with an auth_type of "IAM".
This PR adds the support.
Note that I did not modify the default behaviour if Period is not set, though I suspect it may need to be updated to match what is done in for the EC2 auth_type (for shortest/longestTTL determination).