-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support code for auth/ldap root autorotation #29535
Merged
Merged
+144
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI Results: |
Build Results: |
vinay-gopalan
previously approved these changes
Feb 11, 2025
schavis
requested changes
Feb 12, 2025
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
schavis
approved these changes
Feb 13, 2025
vinay-gopalan
approved these changes
Feb 13, 2025
2 tasks
drivera258
pushed a commit
that referenced
this pull request
Feb 13, 2025
--------- Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the plugin-side code for automated root rotation for auth/ldap.
Note: This feature is Enterprise only and will only work with an Enterprise Vault instance. Tests for the feature will also be added against Vault Enterprise once this PR is merged.
TODO only if you're a HashiCorp employee
backport/
label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x
, but older release branches will bebackport/ent/x.x.x+ent
.in the PR description, commit message, or branch name.