Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support code for auth/ldap root autorotation #29535

Merged
merged 19 commits into from
Feb 13, 2025

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Feb 10, 2025

Description

This PR implements the plugin-side code for automated root rotation for auth/ldap.
Note: This feature is Enterprise only and will only work with an Enterprise Vault instance. Tests for the feature will also be added against Vault Enterprise once this PR is merged.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.

@kpcraig kpcraig added this to the 1.19.0-rc milestone Feb 10, 2025
@kpcraig kpcraig requested a review from a team as a code owner February 10, 2025 16:53
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 10, 2025
Copy link

github-actions bot commented Feb 10, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Feb 10, 2025

Build Results:
All builds succeeded! ✅

@kpcraig kpcraig requested review from a team as code owners February 10, 2025 17:25
@kpcraig kpcraig requested a review from divyapola5 February 10, 2025 17:25
@vinay-gopalan vinay-gopalan removed the request for review from divyapola5 February 11, 2025 20:36
vinay-gopalan
vinay-gopalan previously approved these changes Feb 11, 2025
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@kpcraig kpcraig merged commit db0d911 into main Feb 13, 2025
93 checks passed
@kpcraig kpcraig deleted the VAULT-24967/ldap-root-autorotation branch February 13, 2025 21:06
@kpcraig kpcraig restored the VAULT-24967/ldap-root-autorotation branch February 13, 2025 21:06
drivera258 pushed a commit that referenced this pull request Feb 13, 2025
---------

Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.19.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants