db: allow updates to self_managed_password #29283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
m7mdragab
approved these changes
Jan 4, 2025
vinay-gopalan
approved these changes
Jan 6, 2025
fairclothjm
added a commit
that referenced
this pull request
Jan 7, 2025
6 tasks
fairclothjm
added a commit
that referenced
this pull request
Jan 8, 2025
* secrets/db: enable skip auto import rotation of static roles (#29093) * secrets/db: enable skip auto import rotation of static roles * fix panic due to empty role name causing role to not be stored * fix role upgrade test * Apply suggestions from code review Co-authored-by: vinay-gopalan <86625824+vinay-gopalan@users.noreply.github.com> Co-authored-by: kpcraig <3031348+kpcraig@users.noreply.github.com> * use password in favor of self_managed_password * add deprecated to self_managed_password field * fix bug with allowing updates to password --------- Co-authored-by: vinay-gopalan <86625824+vinay-gopalan@users.noreply.github.com> Co-authored-by: kpcraig <3031348+kpcraig@users.noreply.github.com> * db: fix skip-import-rotation/rootless integration (#29202) * db: fix skip-import-rotation/rootless integration * prevent setting both password and self_managed_password * move func call and add comment * db: allow updates to self_managed_password (#29283) * test: fix ce/ent diff (#29307) --------- Co-authored-by: vinay-gopalan <86625824+vinay-gopalan@users.noreply.github.com> Co-authored-by: kpcraig <3031348+kpcraig@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will allow updates to
self_managed_passwordbefore the first Vault rotation. This is to make the rootless feature inline with the behaviors added in #29093.TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.