Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI: stabilize replication tests into release/1.18.x #28387

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28384 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@hashishaw
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This PR attempts to stabilize flaky replication tests by adding specificity to the test selectors so that we can wait for specific selectors in the tests.


Overview of commits

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Sep 12, 2024
Copy link

hashicorp-cla-app bot commented Sep 12, 2024

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • hashishaw
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

Copy link

github-actions bot commented Sep 12, 2024

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw marked this pull request as ready for review September 13, 2024 14:53
@hashishaw hashishaw requested a review from a team as a code owner September 13, 2024 14:53
* Add specificity to replication title selectors

* Use specific selectors for replication titles in tests
@hashishaw hashishaw added this to the 1.18.0-rc milestone Sep 13, 2024
Copy link

Build Results:
All builds succeeded! ✅

@hashishaw hashishaw enabled auto-merge (squash) September 13, 2024 15:12
@hashishaw hashishaw disabled auto-merge September 13, 2024 15:24
@hashishaw hashishaw merged commit 87cc6ad into release/1.18.x Sep 13, 2024
41 of 53 checks passed
@hashishaw hashishaw deleted the backport/ui/stabilize-replication-tests/visually-selected-turkey branch September 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants