Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix DB Postgres test #28227

Merged
merged 2 commits into from
Aug 29, 2024
Merged

UI: fix DB Postgres test #28227

merged 2 commits into from
Aug 29, 2024

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Aug 29, 2024

Description

After #28199 merged we got failing UI tests because the Postgresql test scenario didn't fill in username/password, which are required now (API responds with error without them)

@hashishaw hashishaw requested a review from a team as a code owner August 29, 2024 20:02
@hashishaw hashishaw added this to the 1.18.0-rc milestone Aug 29, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 29, 2024
Copy link

Build Results:
All builds succeeded! ✅

Copy link

github-actions bot commented Aug 29, 2024

CI Results:
All Go tests succeeded! ✅

@hashishaw hashishaw changed the title UI: stabilize DB Postgres tests? UI: fix DB Postgres test Aug 29, 2024
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling so quickly!

@hashishaw hashishaw merged commit 4de1c69 into main Aug 29, 2024
26 checks passed
@hashishaw hashishaw deleted the ui/stabilize-db-postgres-test branch August 29, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants