Support custom renewal statements in Postgres #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you can do something similar to https://github.com/hashicorp/vault/blob/master/plugins/database/mysql/mysql.go#L165 and have a |
|
Valid. Rewritten to eliminate the split. |
|
I think I inherited those Travis failures from master when I forked. At least I'm hoping I didn't somehow break http from my changes. |
briankassouf
approved these changes
Jun 1, 2017
|
@ConstantineXVI As for the password requirements. You could so something similar to how mysql has multiple implementations for different versions of mysql each with their own username requirements. See https://github.com/hashicorp/vault/blob/master/helper/builtinplugins/builtin.go#L17 for an example |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support a quirk of Redshift that prevents the standard ALTER ROLE from working correctly.
(Related: I want to add the option of adding caps to the generated passwords to meet Redshift's password requirements; but not immediately obvious where to make that configurable)