Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use auth-saved cert name during renewals to avoid a panic. #2755

Merged
merged 2 commits into from
May 24, 2017
Merged

Conversation

jefferai
Copy link
Member

Fixes #2749

@jefferai jefferai added this to the 0.7.3 milestone May 23, 2017
Copy link
Contributor

@calvn calvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@vishalnayak vishalnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM.

@@ -156,7 +156,12 @@ func (b *backend) verifyCredentials(req *logical.Request, d *framework.FieldData
clientCert := connState.PeerCertificates[0]

// Allow constraining the login request to a single CertEntry
certName := d.Get("name").(string)
var string certName
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull requests works fine, after changing the typo var string certName to var certName string. Thank!

@jefferai jefferai merged commit 6164690 into master May 24, 2017
@jefferai jefferai deleted the issue-2749 branch May 24, 2017 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants