Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new clients to namespace counts #27549

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

miagilepner
Copy link
Contributor

Description

I realized I missed something when reviewing the original PR - this needs to be adding the new counts to the existing precomputed query, not the total counts. My bad!!

Updated the test to verify that we're combining the NewClients.Namespaces field, and not Namespaces.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.18.0-rc milestone Jun 20, 2024
@miagilepner miagilepner requested a review from divyaac June 20, 2024 12:50
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 20, 2024
@miagilepner miagilepner mentioned this pull request Jun 20, 2024
6 tasks
@miagilepner miagilepner enabled auto-merge (squash) June 20, 2024 12:55
@divyaac
Copy link
Contributor

divyaac commented Jun 20, 2024

Thanks for catching this!! Approved, just pending tests

Copy link

CI Results:
All Go tests succeeded! ✅

Copy link

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner merged commit 9af5c5c into main Jun 20, 2024
105 checks passed
@miagilepner miagilepner deleted the miagilepner/combine-new-clients branch June 20, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants