Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: allow setting auto-auth and vault.namespace separately #26427

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Apr 15, 2024

The new vault.namespace config option seems to always be overridden by the auto-auth namespace, so this adds an extra check to allow them to be set separately.

The new vault.namespace config option seems to always be overridden by
the auto-auth namespace, so add an extra check to allow them to be set
separately.
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 15, 2024
@tvoran tvoran added this to the 1.16.2 milestone Apr 15, 2024
Copy link

github-actions bot commented Apr 15, 2024

CI Results:
All Go tests succeeded! ✅

@tvoran tvoran marked this pull request as ready for review April 15, 2024 19:29
@tvoran tvoran requested a review from VioletHynes April 15, 2024 19:38
changelog/26427.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Minor comment on the changelog that you can take or leave. Thanks for fixing this!

Copy link

Build Results:
All builds succeeded! ✅

tvoran and others added 2 commits April 15, 2024 13:47
@tvoran
Copy link
Member Author

tvoran commented Apr 15, 2024

Thanks!

@tvoran tvoran enabled auto-merge (squash) April 15, 2024 20:47
@tvoran tvoran merged commit 6df779f into main Apr 15, 2024
83 checks passed
@tvoran tvoran deleted the VAULT-23538/agent-template-namespace branch April 15, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants