Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent Auto Auth Self Healing for Templates #26172

Merged
merged 4 commits into from
Mar 27, 2024
Merged

Agent Auto Auth Self Healing for Templates #26172

merged 4 commits into from
Mar 27, 2024

Conversation

divyaac
Copy link
Contributor

@divyaac divyaac commented Mar 26, 2024 •
edited
Loading

This PR adds the ability for Agent to re-trigger auto auth, when consul-template recieves an "invalid token" error while rendering a template.

closes https://github.com/hashicorp/vault-enterprise/pull/5627

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Mar 26, 2024
@divyaac divyaac added this to the 1.17.0-rc milestone Mar 26, 2024
@divyaac divyaac requested a review from VioletHynes March 26, 2024 21:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

CI Results:
All Go tests succeeded! ✅

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2024 •
edited
Loading

Build Results:
All builds succeeded! ✅

VioletHynes
VioletHynes reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I thought the previous PR I was reviewing was a CE PR. I noticed none of the files were enterprise only, and these affect the same 21 files--what's the difference in the diff? This one has -41 lines and the other had -44.

@divyaac
Copy link
Contributor Author

divyaac commented Mar 27, 2024

Apologies, I thought the previous PR I was reviewing was a CE PR. I noticed none of the files were enterprise only, and these affect the same 21 files--what's the difference in the diff? This one has -41 lines and the other had -44.

I believe the diff is in the go.mod and go.sum files. I cleaned it up here to make all the builds pass properly (versus in the enterprise)

@divyaac divyaac merged commit 6cac3b3 into main Mar 27, 2024
78 checks passed
@divyaac divyaac deleted the VAULT-23741_Agent_Self_Healing_Auto_Auth branch March 27, 2024 17:06
@peteski22 peteski22 added the agent label Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VioletHynes VioletHynes VioletHynes approved these changes

Assignees
No one assigned
Labels
agent hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
1.17.0-rc
Development

Successfully merging this pull request may close these issues.
3 participants
@divyaac @VioletHynes @peteski22