Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mssql driver update #2610

Merged
merged 2 commits into from
Apr 18, 2017
Merged

Mssql driver update #2610

merged 2 commits into from
Apr 18, 2017

Conversation

chrishoffman
Copy link
Contributor

A few updates that address current issues in the MSSQL backend.

  • Update the driver from mssql to sqlserver. This is recommended by the sql server client author to address parsing issues with interpreting colons as parameters in sql statement.
  • Adding an explicit database to the stored procedure call in case the context of the connection is not in the master database.

I manually ran the acceptance tests and they are passing.

Fixes #2606

briankassouf
briankassouf approved these changes Apr 18, 2017
View reviewed changes
Copy link
Contributor

@briankassouf briankassouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@chrishoffman chrishoffman merged commit 6b55ab5 into master Apr 18, 2017
@chrishoffman chrishoffman deleted the mssql-driver-update branch April 18, 2017 21:50
@jefferai jefferai added this to the 0.7.1 milestone Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briankassouf briankassouf briankassouf approved these changes

@jefferai jefferai Awaiting requested review from jefferai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@chrishoffman @briankassouf @jefferai