UI: [VAULT-21530] Custom Messages List View w/ Pagination and LazyPaginatedQuery

[kiannaquach]

Custom Banners List View

TODO:

• Write serializer and adapter tests (VAULT-22047 tests and mirage)
• Write more integration tests for messages list view and refactor it to use mirage handler (VAULT-22047 tests and mirage)
• Refactor mirage so it can generate more list data (VAULT-22047 tests and mirage)
• Search by name in the toolbar filters (VAULT-22046)

[kiannaquach]

An issue I ran into: when transitioning to different tabs, the page query params are retained from the previous tab. This is the default behavior since controllers are singletons. I tried adding a resetController to reset the page to 1. I noticed that we have explicitly state what the query params are in order for the tabs to transition with the correct query params. Here's a similar description of what I saw happening: https://guides.emberjs.com/v2.14.0/routing/query-params/

[Monkeychip]

You should be able to reset to null. Let's zoom through this as it gets a little confusing. Ex:

resetController(controller, isExiting) {
    if (isExiting) {
      controller.set('pageFilter', null);
      controller.set('page', null);
    }
  }

[github-actions]

Build Results:
All builds succeeded! ✅

[Monkeychip]

What if query is false? Does the API error? You might want to consider a catch statement here and doing something with the error if it's a 404 (no response, e.g. no items in the list) vs anything else like a 403. There is a good example of this on the ldap library adapter.

[kiannaquach]

I originally had a try/catch here but the 404/403 error didn't bubble to the query. Since I'm using lazyPaginatedQuery, I did the try/catch in the route instead and the errors get surfaced in there. https://github.com/hashicorp/vault/pull/24133/files#diff-5a46be6bfd29de6b487be8b6242b62bdd861524c47cc1fb10eb4a876e00c129f

[Monkeychip]

You should be able to reset to null. Let's zoom through this as it gets a little confusing. Ex:

resetController(controller, isExiting) {
    if (isExiting) {
      controller.set('pageFilter', null);
      controller.set('page', null);
    }
  }

[Monkeychip]

you might also try using the ember truth-helper not. https://github.com/jmurphyau/ember-truth-helpers. It reads easier than unless.

[kiannaquach]

The linter recommends unless instead of if not @authenticated🫠

[Monkeychip]

TIL.

[Monkeychip]

Great work! 🙌🏻