Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui/pricing metrics page setup #10049

Merged
merged 14 commits into from
Oct 1, 2020
Merged

Ui/pricing metrics page setup #10049

merged 14 commits into from
Oct 1, 2020

Conversation

chelshaw
Copy link
Contributor

@chelshaw chelshaw commented Sep 28, 2020

This PR sets up the Pricing Metrics UI page (currently based on mock data from the endpoint). This is the bare-bones version of this page, without date filtering or namespaces. Metrics are seen at the route /ui/vault/metrics while the config is at /ui/vault/metrics-config.

metrics-with-result-dates

When disabled but there is data:
metrics-enabled-off

Config:
metrics-page

TODOS:

  • Remove http-entities and other old models for metrics

@chelshaw chelshaw marked this pull request as ready for review September 28, 2020 20:35
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a test failure. But this looks good. Same with the naming. Are we going to go live with this before the API endpoint is ready?

ui/app/controllers/vault/cluster/metrics-config.js Outdated Show resolved Hide resolved
ui/tests/unit/models/metrics/activity-test.js Outdated Show resolved Hide resolved
@chelshaw
Copy link
Contributor Author

Looks like a test failure. But this looks good. Same with the naming. Are we going to go live with this before the API endpoint is ready?

Good question, we can either merge this (and all forthcoming work) into a sidebranch until we know the API will be ready for release, or merge now and be prepared to revert later. My concern with a sidebranch is that when the ember upgrade is finished we'll have to do that process again for this new work, but hopefully since it's a small section it won't be too painful. Thoughts @Monkeychip ?

@chelshaw chelshaw added the ui label Oct 1, 2020
@chelshaw chelshaw added this to the 1.6 milestone Oct 1, 2020
@chelshaw chelshaw merged commit 79a982e into master Oct 1, 2020
@chelshaw chelshaw deleted the ui/pricing-metrics-page-setup branch October 1, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants