-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ui/pricing metrics page setup #10049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a test failure. But this looks good. Same with the naming. Are we going to go live with this before the API endpoint is ready?
Good question, we can either merge this (and all forthcoming work) into a sidebranch until we know the API will be ready for release, or merge now and be prepared to revert later. My concern with a sidebranch is that when the ember upgrade is finished we'll have to do that process again for this new work, but hopefully since it's a small section it won't be too painful. Thoughts @Monkeychip ? |
This PR sets up the Pricing Metrics UI page (currently based on mock data from the endpoint). This is the bare-bones version of this page, without date filtering or namespaces. Metrics are seen at the route
/ui/vault/metrics
while the config is at/ui/vault/metrics-config
.When disabled but there is data:
Config:
TODOS: