You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
I prefer to use the latest versions of dependent projects. vault/api uses github.com/cenkalti/backoff/v3, although v4 has been released since 2020.
Describe the solution you'd like
Update the dependency in vault/api/lifetime_watcher.go to github.com/cenkalti/backoff/v4.
Describe alternatives you've considered
I am not sure if this is a feature request or a bug report...
Explain any additional use-cases
This should be an easy and compatible change.
Additional context
For projects that use multiple different packages, it is easier if all of the packages use the latest version of transitive dependencies, otherwise you end up with multiple versions of the same code in the executable (not a functional problem, go handles this well, just a problem of code hygiene).
The text was updated successfully, but these errors were encountered:
This makes it so projects that are already using backoff don't need to
pull up an old version of it just because of vault/api. This major
version change is compatible with existing usage in code.
Refs hashicorp#24707.
This makes it so projects that are already using backoff don't need to
pull up an old version of it just because of vault/api. This major
version change is compatible with existing usage in code.
Refs #24707.
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Is your feature request related to a problem? Please describe.
I prefer to use the latest versions of dependent projects.
vault/api
usesgithub.com/cenkalti/backoff/v3
, althoughv4
has been released since 2020.Describe the solution you'd like
Update the dependency in
vault/api/lifetime_watcher.go
togithub.com/cenkalti/backoff/v4
.Describe alternatives you've considered
I am not sure if this is a feature request or a bug report...
Explain any additional use-cases
This should be an easy and compatible change.
Additional context
For projects that use multiple different packages, it is easier if all of the packages use the latest version of transitive dependencies, otherwise you end up with multiple versions of the same code in the executable (not a functional problem, go handles this well, just a problem of code hygiene).
The text was updated successfully, but these errors were encountered: