Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency in the vault/api #24707

Open
kgadams opened this issue Jan 8, 2024 · 0 comments
Open

Update dependency in the vault/api #24707

kgadams opened this issue Jan 8, 2024 · 0 comments

Comments

@kgadams
Copy link

kgadams commented Jan 8, 2024

Is your feature request related to a problem? Please describe.
I prefer to use the latest versions of dependent projects. vault/api uses github.com/cenkalti/backoff/v3, although v4 has been released since 2020.

Describe the solution you'd like
Update the dependency in vault/api/lifetime_watcher.go to github.com/cenkalti/backoff/v4.

Describe alternatives you've considered
I am not sure if this is a feature request or a bug report...

Explain any additional use-cases
This should be an easy and compatible change.

Additional context
For projects that use multiple different packages, it is easier if all of the packages use the latest version of transitive dependencies, otherwise you end up with multiple versions of the same code in the executable (not a functional problem, go handles this well, just a problem of code hygiene).

crazybolillo added a commit to crazybolillo/vault that referenced this issue May 28, 2024
This makes it so projects that are already using backoff don't need to
pull up an old version of it just because of vault/api. This major
version change is compatible with existing usage in code.

Refs hashicorp#24707.
VioletHynes added a commit that referenced this issue May 29, 2024
This makes it so projects that are already using backoff don't need to
pull up an old version of it just because of vault/api. This major
version change is compatible with existing usage in code.

Refs #24707.

Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant