-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into ui/stretch-text-field-to-fit-content-in-JSON…
…-editor
- Loading branch information
Showing
33 changed files
with
1,310 additions
and
148 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright (c) HashiCorp, Inc. | ||
// SPDX-License-Identifier: BUSL-1.1 | ||
|
||
package transit | ||
|
||
import ( | ||
"fmt" | ||
|
||
"github.com/hashicorp/vault/sdk/helper/keysutil" | ||
) | ||
|
||
// parsePaddingSchemeArg validate that the provided padding scheme argument received on the api can be used. | ||
func parsePaddingSchemeArg(keyType keysutil.KeyType, rawPs any) (keysutil.PaddingScheme, error) { | ||
ps, ok := rawPs.(string) | ||
if !ok { | ||
return "", fmt.Errorf("argument was not a string: %T", rawPs) | ||
} | ||
|
||
paddingScheme, err := keysutil.ParsePaddingScheme(ps) | ||
if err != nil { | ||
return "", err | ||
} | ||
|
||
if !keyType.PaddingSchemesSupported() { | ||
return "", fmt.Errorf("unsupported key type %s for padding scheme", keyType.String()) | ||
} | ||
|
||
return paddingScheme, nil | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
// Copyright (c) HashiCorp, Inc. | ||
// SPDX-License-Identifier: BUSL-1.1 | ||
|
||
package transit | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/hashicorp/vault/sdk/helper/keysutil" | ||
) | ||
|
||
// Test_parsePaddingSchemeArg validate the various use cases we have around parsing | ||
// the various padding_scheme arg possible values. | ||
func Test_parsePaddingSchemeArg(t *testing.T) { | ||
type args struct { | ||
keyType keysutil.KeyType | ||
rawPs any | ||
} | ||
tests := []struct { | ||
name string | ||
args args | ||
want keysutil.PaddingScheme | ||
wantErr bool | ||
}{ | ||
// Error cases | ||
{name: "nil-ps", args: args{keyType: keysutil.KeyType_RSA2048, rawPs: nil}, wantErr: true}, | ||
{name: "nonstring-ps", args: args{keyType: keysutil.KeyType_RSA2048, rawPs: 5}, wantErr: true}, | ||
{name: "invalid-ps", args: args{keyType: keysutil.KeyType_RSA2048, rawPs: "unknown"}, wantErr: true}, | ||
{name: "bad-keytype-oaep", args: args{keyType: keysutil.KeyType_AES128_CMAC, rawPs: "oaep"}, wantErr: true}, | ||
{name: "bad-keytype-pkcs1", args: args{keyType: keysutil.KeyType_ECDSA_P256, rawPs: "pkcs1v15"}, wantErr: true}, | ||
{name: "oaep-capped", args: args{keyType: keysutil.KeyType_RSA4096, rawPs: "OAEP"}, wantErr: true}, | ||
{name: "pkcs1-whitespace", args: args{keyType: keysutil.KeyType_RSA3072, rawPs: " pkcs1v15 "}, wantErr: true}, | ||
|
||
// Valid cases | ||
{name: "oaep-2048", args: args{keyType: keysutil.KeyType_RSA2048, rawPs: "oaep"}, want: keysutil.PaddingScheme_OAEP}, | ||
{name: "oaep-3072", args: args{keyType: keysutil.KeyType_RSA3072, rawPs: "oaep"}, want: keysutil.PaddingScheme_OAEP}, | ||
{name: "oaep-4096", args: args{keyType: keysutil.KeyType_RSA4096, rawPs: "oaep"}, want: keysutil.PaddingScheme_OAEP}, | ||
{name: "pkcs1", args: args{keyType: keysutil.KeyType_RSA3072, rawPs: "pkcs1v15"}, want: keysutil.PaddingScheme_PKCS1v15}, | ||
} | ||
for _, tt := range tests { | ||
t.Run(tt.name, func(t *testing.T) { | ||
got, err := parsePaddingSchemeArg(tt.args.keyType, tt.args.rawPs) | ||
if (err != nil) != tt.wantErr { | ||
t.Errorf("parsePaddingSchemeArg() error = %v, wantErr %v", err, tt.wantErr) | ||
return | ||
} | ||
if got != tt.want { | ||
t.Errorf("parsePaddingSchemeArg() got = %v, want %v", got, tt.want) | ||
} | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.