cleanups after feedback

hashicorp · Sep 6, 2018 · c5f6049 · c5f6049
1 parent 486fc3f
commit c5f6049
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/builtin/logical/aws/secret_access_keys.go b/builtin/logical/aws/secret_access_keys.go
@@ -119,6 +119,8 @@ func (b *backend) secretTokenCreate(ctx context.Context, s logical.Storage,
 func (b *backend) assumeRole(ctx context.Context, s logical.Storage,
 	displayName, roleName, roleArn, policy string,
 	lifeTimeInSeconds int64) (*logical.Response, error) {
+	b.clientMutex.Lock()
+	defer b.clientMutex.Unlock()
 	if b.stsClient == nil {
 		stsClient, err := clientSTS(ctx, s)
 		if err != nil {

diff --git a/helper/awsutil/error.go b/helper/awsutil/error.go
@@ -7,7 +7,7 @@ import (
 )
 
 // CheckAWSError will examine an error and convert to a logical error if
-// approrpiate. If no appropriate error is found, return nil
+// appropriate. If no appropriate error is found, return nil
 func CheckAWSError(err error) error {
 	// IsErrorThrottle will check if the error returned is one that matches
 	// known request limiting errors:

diff --git a/logical/error.go b/logical/error.go
@@ -21,7 +21,7 @@ var (
 	// authorizations
 	ErrMultiAuthzPending = errors.New("request needs further approval")
 
-	// ErrUpstreamRateLimited is returned when Vault recieves a rate limited
+	// ErrUpstreamRateLimited is returned when Vault receives a rate limited
 	// response from an upstream
 	ErrUpstreamRateLimited = errors.New("upstream rate limited")
 )