VAULT-20403 fix incorrectly deferred resource closure in debug command (

#26167) * VAULT-20403 fix incorrectly deferred resource closure in debug command * VAULT-20403 changelog
hashicorp · Mar 27, 2024 · 2a33300 · 2a33300
1 parent 5fac327
commit 2a33300
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/changelog/26167.txt b/changelog/26167.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+cli/debug: Fix resource leak in CLI debug command.
+```
diff --git a/command/debug.go b/command/debug.go
@@ -687,17 +687,18 @@ func (c *DebugCommand) collectHostInfo(ctx context.Context) {
 			return
 		}
 		if resp != nil {
-			defer resp.Body.Close()
-
 			secret, err := api.ParseSecret(resp.Body)
 			if err != nil {
 				c.captureError("host", err)
+				resp.Body.Close()
 				return
 			}
 			if secret != nil && secret.Data != nil {
 				hostEntry := secret.Data
 				c.hostInfoCollection = append(c.hostInfoCollection, hostEntry)
 			}
+
+			resp.Body.Close()
 		}
 	}
 }