A bunch of little fixes #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvn
reviewed
Feb 17, 2021
path_dynamic_roles.go
Outdated
| @@ -18,8 +18,8 @@ import ( | |||
| const ( | |||
| secretCredsType = "creds" | |||
|
|
|||
| dynamicRolePath = "role/" | |||
| dynamicCredPath = "cred/" | |||
| dynamicRolePath = "roles/" | |||
calvn
reviewed
Feb 17, 2021
scripts/acceptance-tests.bats
Outdated
| @@ -183,11 +183,11 @@ teardown() { | |||
| vault delete openldap/config | |||
|
|
|||
| # Remove any roles that were created so they don't bleed over to other tests | |||
| output=$(vault list -format=json openldap/role || true) # "or true" so it doesn't show an error if there are no roles | |||
| output=$(vault list -format=json openldap/roles || true) # "or true" so it doesn't show an error if there are no roles | |||
There was a problem hiding this comment.
You'd have to revert these paths as well 😄
calvn
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cred->/credsprefixargument from static creds endpoint (it isn't supported & was creating problems with thepath-helpcommand on Vault)