Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace breaking errors when skipping resources with logs #225

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

vinay-gopalan
Copy link
Contributor

Overview

The make generate target generates IAM resources dynamically. It uses Google's IAM Discovery API to query the resources/APIs that Google supports. Google regularly updates these with new APIs, changes and versions, and at times the responses from a particular APIs server can be flaky (See passing and failing builds for the same resources, only a few days apart).

Currently, the flaky responses from the servers (404s or 500s) break the build for the plugin (since make dev depends on the generate target). Ideally, we would simply log to the console that we are skipping a particular API because we did not receive the appropriate response from the server, instead of completely breaking CI and the build. This PR replaces the breaking error with a warning log.

Other changes:

  • Updated/Added generated resources based on new API changes from Google.

@vinay-gopalan vinay-gopalan requested a review from a team September 9, 2024 17:03
@vinay-gopalan vinay-gopalan merged commit 18a42f2 into main Sep 9, 2024
2 checks passed
@vinay-gopalan vinay-gopalan deleted the generate/log-insteadof-error branch September 9, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants