Replace breaking errors when skipping resources with logs #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
make generate
target generates IAM resources dynamically. It uses Google's IAM Discovery API to query the resources/APIs that Google supports. Google regularly updates these with new APIs, changes and versions, and at times the responses from a particular APIs server can be flaky (See passing and failing builds for the same resources, only a few days apart).Currently, the flaky responses from the servers (404s or 500s) break the build for the plugin (since
make dev
depends on thegenerate
target). Ideally, we would simply log to the console that we are skipping a particular API because we did not receive the appropriate response from the server, instead of completely breaking CI and the build. This PR replaces the breaking error with a warning log.Other changes: