Fix a couple of bugs in #216 #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eh-steve
force-pushed
the
VAULT-26464/fix-update-resources-target-bugfixes
branch
from
2724d90
to
9da9799
Compare
vinay-gopalan
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Thanks for the fix @eh-steve and sorry for the delay on the review! 🙏🏼
The fix looks good, and I can merge these to run against the tests on upstream PR. Thanks again!
vinay-gopalan
merged commit 24310fb
into
hashicorp:VAULT-26464/fix-update-resources-target
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#216 has a couple of bugs