Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape URL in CLI helper on Windows #37

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Escape URL in CLI helper on Windows #37

merged 1 commit into from
Apr 1, 2019

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Apr 1, 2019

Fixes #36

@kalafut kalafut requested a review from ncabatoff April 1, 2019 16:46
ncabatoff
ncabatoff approved these changes Apr 1, 2019
View reviewed changes
Copy link

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is a strings.ReplaceAll which is slightly more readable. I'm fine with current patch though.

@kalafut
Copy link
Contributor Author

kalafut commented Apr 1, 2019

strings.ReplaceAll is a Go 1.12 feature I'd like to use, but I think we're still holding off on 1.12 for the time being.

@kalafut kalafut merged commit 7b19d4b into master Apr 1, 2019
@kalafut kalafut deleted the fix-windows-cli branch April 1, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalafut @ncabatoff