chore: remove unused validateAudience function

[tenstad]

Overview

Removes the unused validateAudience function

vault-plugin-auth-jwt/claims.go

Lines 92 to 110 in a847fcb

	// validateAudience checks whether any of the audiences in audClaim match those
	// in boundAudiences. If strict is true and there are no bound audiences, then the
	// presence of any audience in the received claim is considered an error.
	func validateAudience(boundAudiences, audClaim []string, strict bool) error {
	if strict && len(boundAudiences) == 0 && len(audClaim) > 0 {
	return errors.New("audience claim found in JWT but no audiences bound to the role")
	}
	if len(boundAudiences) > 0 {
	for _, v := range boundAudiences {
	if strutil.StrListContains(audClaim, v) {
	return nil
	}
	}
	return errors.New("aud claim does not match any bound audience")
	}
	return nil
	}

as the one in hashicorp/cap/jwt/jwt.go is used instead, as part of

vault-plugin-auth-jwt/path_login.go

Lines 152 to 156 in a847fcb

	// Validate the JWT by verifying its signature and asserting expected claims values
	allClaims, err := validator.Validate(ctx, token, expected)
	if err != nil {
	return logical.ErrorResponse("error validating token: %s", err.Error()), nil
	}

Design of Change

To not confuse those reading the source and expecting this repo's validateAudience to be in use.

Contributor Checklist

• Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
• Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
• Backwards compatible