Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable multiplexing #96

Merged
merged 3 commits into from
Feb 23, 2023
Merged

enable multiplexing #96

merged 3 commits into from
Feb 23, 2023

Conversation

raymonstah
Copy link
Contributor

Overview

  • the plugin will be multiplexed when run as an external plugin against vault versions that support plugin multiplexing
  • we continue to set the TLSProviderFunc to maintain backwards compatibility with vault versions that don't support AutoMTLS (< 1.12)

@raymonstah raymonstah requested review from fairclothjm and a team February 22, 2023 23:12
vinay-gopalan
vinay-gopalan approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Had a couple of nits/small comments but other than that everything looks great 👍🏼

go.mod Outdated
golang.org/x/oauth2 v0.4.0
)

require github.com/hashicorp/go-kms-wrapping/v2 v2.0.7 // indirect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably add this to the require block below and run go mod tidy. Not sure why Go added this separately 🤔

CHANGELOG.md Outdated
@@ -1,5 +1,13 @@
## Unreleased

CHANGES:

* ADD YOUR CHANGE HERE [GH-XXX]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can skip the CHANGES section since we only need the Improvements

@raymonstah raymonstah merged commit ee6cf5d into main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fairclothjm fairclothjm fairclothjm approved these changes

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raymonstah @fairclothjm @vinay-gopalan