Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error parsing for valid JSON responses #247

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Fix error parsing for valid JSON responses #247

merged 3 commits into from
Dec 13, 2023

Conversation

averche
Copy link
Collaborator

@averche averche commented Dec 11, 2023

Description

When parsing error responses, if the message does not include "errors" or "error" JSON elements, the ResponseError.RawResponseBytes will be populated:

s, err := client.Secrets.KvV2Read(ctx, "my-secret", vault.WithMountPath("secret"))
if err != nil {
    var e *vault.ResponseError
    if errors.As(err, &responseError) {
        log.Printf("response status code: %d", e.StatusCode)
        log.Printf("response body: %s", e.RawResponseBytes)
    } else {
        log.Println(err)
    }
}
assert(s == nil)

Resolves #246

How has this been tested?

Added a unit test.

@averche averche marked this pull request as ready for review December 12, 2023 00:30
@averche averche requested a review from a team as a code owner December 12, 2023 00:30
@averche averche merged commit 6a3609c into main Dec 13, 2023
4 checks passed
@averche averche deleted the error-parsing branch December 13, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading deleted secrets failed due to 404 response from Vault
2 participants