-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle new 'predictable' network interface naming style #7241
Closed
dougneal
wants to merge
2
commits into
hashicorp:master
from
dougneal:linux_predictable_interface_names
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
#VAGRANT-BEGIN | ||
# The contents below are automatically generated by Vagrant. Do not modify. | ||
auto eth<%= options[:interface] %> | ||
iface eth<%= options[:interface] %> inet dhcp | ||
auto <%= kernel_ifnames[options[:interface]] %> | ||
iface <%= kernel_ifnames[options[:interface]] %> inet dhcp | ||
<% if !options[:use_dhcp_assigned_default_route] %> | ||
post-up route del default dev $IFACE || true | ||
<% else %> | ||
# We need to disable eth0, see GH-2648 | ||
post-up route del default dev eth0 || true | ||
# We need to disable <%= kernel_ifnames[0] %>, see GH-2648 | ||
post-up route del default dev <%= kernel_ifnames[0] %> || true | ||
post-up dhclient $IFACE | ||
pre-down route add default dev eth0 | ||
pre-down route add default dev <%= kernel_ifnames[0] %> | ||
<% end %> | ||
#VAGRANT-END |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is technically correct. My systemd based machine (though not Ubuntu) has an ethernet adapter named
enp0s31f6
. This wouldn't be caught by this RE.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would only be for debian-based guests... is your machine running a Debian derivative, or something else (e.g. RHEL)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debian GNU/Linux stretch/sid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name format appears to be described in systemd's udev-builtin-net_id.c