[WIP] provider/aws: Add new aws_vpc_endpoint_route_table_association resource.

[kwilczynski]

This commit adds a new resource which allows to a list of route tables to be
either added and/or removed from an existing VPC Endpoint. This resource would
also be complimentary to the existing aws_vpc_endpoint resource where the
route tables might not be specified (not a requirement for a VPC Endpoint to
be created successfully) during creation, especially where the workflow is
such where the route tables are not immediately known.

Signed-off-by: Krzysztof Wilczynski krzysztof.wilczynski@linux.com

[kwilczynski]

Things to do:

• Add implementation for resource lifecycle:
  • Create association
  • Read details about VPC Endpoint
  • Update association
  • Delete association
• Add acceptance test
• Manually test different scenarios
• Add documentation

[ewbankkit]

@kwilczynski Any reason this was closed? We need this functionality and would like to help in getting implemented.

[kwilczynski]

@ewbankkit hi there! Apologies!

I had some doubts whether I will be able to continue working on this, but it seem that everything is on a right track.

[ewbankkit]

@kwilczynski: I have taken a stab at implementing this functionality here: https://github.com/ewbankkit/terraform/tree/issue-9138.

I started with your initial commit and modified the functionality slightly to allow only one Route Table ID per association; Multiple route table can be handled via multiple association resources or using a count attribute - This made the implementation easier 😄.
I also added documentation and acceptance tests.
Since there is now potential conflict with the route_table_ids attribute of the usual aws_vpc_endpoint resource I updated its documentation and also changed the route_table_ids to be a computed attribute (similar to inline rules in NACLs or Security Groups). You can take this if you want to build on it or I can submit a PR - Let me know.

[ewbankkit]

@kwilczynski Are you OK with me creating a PR based on https://github.com/ewbankkit/terraform/tree/issue-9138? I'd like to try and get this considered for TF 0.8.

[kwilczynski]

@ewbankkit hi there. Go ahead, I am going to close this one.

[kwilczynski]

@ewbankkit hi there again.

I had a look at the code. Would you be able to consider things like e.g. allow multiple route tables to be passed as a list (eventually, people are going to ask about this) which is why UpdateFunc might be useful, as there can be an existing association that needs new route tables to be added and/or removed from it accordingly, etc.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.