providers/aws: Check error from resourceAwsRoute53RecordBuildSet and return err if set #8399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
| @@ -270,6 +270,9 @@ func resourceAwsRoute53RecordCreate(d *schema.ResourceData, meta interface{}) er | |||
| zone, *rec.Name, req) | |||
|
|
|||
| respRaw, err := changeRoute53RecordSet(conn, req) | |||
| if err != nil { | |||
| return err | |||
There was a problem hiding this comment.
Do we want to wrap this in something explaining the provenance of the error?
There was a problem hiding this comment.
Good idea, are you thinking a simple return fmt.Errorf("[ERR]: Error building changeset: %s", err) or something involving errwrap?
There was a problem hiding this comment.
I was thinking:
return errwrap.Wrapf("[ERR]: Error building changeset: {{err}}", err)
|
Tests pass, merging |
c4milo
added a commit
to hooklift/terraform
that referenced
this pull request
Aug 23, 2016
* master: (100 commits) Update CHANGELOG.md providers/aws: Check error from resourceAwsRoute53RecordBuildSet and return err if set (hashicorp#8399) Update CHANGELOG.md provider/aws: Add support for ECS svc - LB target group (hashicorp#8190) Added example of how the Option settings works (hashicorp#8413) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md provider/aws: Add support for `network_mode` to `aws_ecs_task_definition` (hashicorp#8391) Update CHANGELOG.md Update CHANGELOG.md provider/aws: Add Primary Endpoint Address output for (hashicorp#8385) Update CHANGELOG.md provider/aws: `aws_elasticache_replication_group_id` validation change (hashicorp#8381) provider/google: Remove redundant type declaration provider/google: Hook in state migration function provider/openstack: docs and tests for allowed_address_pairs Update CHANGELOG.md website: Docs for AWS API Gateway domain name and base path mapping provider/aws: aws_api_gateway_base_path_mapping resource implementation ...
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address the possible panic reported in #8393. I have not been able to reproduce firsthand, I see the possibilities.