Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Add support for network_mode to aws_ecs_task_definition #8391

Merged
merged 3 commits into from
Aug 23, 2016

Commits on Aug 23, 2016

  1. provider/aws: Add support for network_mode to

    `aws_ecs_task_definition`
    
    Fixes #8281
    
    ```
    
    ```
    make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSEcsTaskDefinition_'
    ==> Checking that code complies with gofmt requirements...
    /Users/stacko/Code/go/bin/stringer
    go generate $(go list ./... | grep -v /terraform/vendor/)
    2016/08/22 18:12:20 Generated command/internal_plugin_list.go
    TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSEcsTaskDefinition_ -timeout 120m
    === RUN   TestAccAWSEcsTaskDefinition_basic
    --- PASS: TestAccAWSEcsTaskDefinition_basic (29.02s)
    === RUN   TestAccAWSEcsTaskDefinition_withScratchVolume
    --- PASS: TestAccAWSEcsTaskDefinition_withScratchVolume (16.75s)
    === RUN   TestAccAWSEcsTaskDefinition_withEcsService
    --- PASS: TestAccAWSEcsTaskDefinition_withEcsService (147.77s)
    === RUN   TestAccAWSEcsTaskDefinition_withTaskRoleArn
    --- PASS: TestAccAWSEcsTaskDefinition_withTaskRoleArn (19.49s)
    === RUN   TestAccAWSEcsTaskDefinition_withNetworkMode
    --- PASS: TestAccAWSEcsTaskDefinition_withNetworkMode (19.52s)
    PASS
    ok  	github.com/hashicorp/terraform/builtin/providers/aws	232.588
    stack72 committed Aug 23, 2016
    Configuration menu
    Copy the full SHA
    73f98c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1ded81b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7cb4087 View commit details
    Browse the repository at this point in the history