Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/aws: Fix data.aws_iam_policy_document #7611

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Jul 12, 2016

Adds ID and Version support to policy documents.

Fixes #7499.

@@ -71,14 +72,15 @@ valid to use literal JSON strings within your configuration, or to use the

The following arguments are supported:

* `id` (Optional) - An ID for the policy document.
* `version` (Optional) - An policy version. Defaults to `2012-10-17`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably document that if you set this to 2008-10-17 then you can't use policy variables.

(Though I don't know why anyone would set this to anything other than what it defaults to anyway.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apparentlymart the reason I had was for existing ones what shouldn't be modified (for whatever reason) - happy to point out in the docs that the default should be fine for almost all use cases though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually having researched this I am in agreement @apparentlymart, and will remove version again.

We cannot use the "id" field to represent policy ID, because it is used
internally by Terraform. Also change the "id" field within a statement
to "sid" for consistency with the generated JSON.
@jen20 jen20 force-pushed the b-iam-policy-document-fixes branch from 8cb9970 to 28438da Compare July 13, 2016 18:10
@jen20 jen20 merged commit 30ff7df into master Jul 13, 2016
@jen20 jen20 deleted the b-iam-policy-document-fixes branch July 13, 2016 18:21
@ghost
Copy link

ghost commented Apr 24, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_iam_policy_document data don't generate ids properties
3 participants