provider/azurerm: Add azurerm_virtual_machine_scale_set resource

[stack72]

• Schema
• CRUD
• Acceptance Tests
• Documentation

make testacc TEST=./builtin/providers/azurerm TESTARGS='-run=TestAccAzureRMVirtualMachineScaleSet'
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /vendor/)
TF_ACC=1 go test ./builtin/providers/azurerm -v -run=TestAccAzureRMVirtualMachineScaleSet -timeout 120m
=== RUN   TestAccAzureRMVirtualMachineScaleSet_basicLinux
--- PASS: TestAccAzureRMVirtualMachineScaleSet_basicLinux (706.89s)

[phinze]

Commented bits here. Not sure if they need to be in or are a TODO?

[phinze]

Looking great overall! Some in line Qs for you above, and one overall question on attr naming ->

I see that a lot of the blocks are virtual_machine_{thing} - I understand this is flattening to work around helper/schema's problems dealing with deeply nested structs. I wonder if so much of the config is virtual_machine_ prefixed that it might make sense to drop that?

I think once we get the deep-nested attributes bugs sorted we'll move everything over to that, but in the meantime just a thought that might make the "flattened workaround" style config a big cleaner.

[phinze]

LGTM with edits!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.