actions: validate that action referenced in action_trigger exists in config during transform #37559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildwonkey
added
the
no-changelog-needed
mildwonkey
force-pushed
the
mildwonkey/action-trigger-validation
branch
from
2ebd207 to
f8f3ceb
Compare
…config during transform
mildwonkey
force-pushed
the
mildwonkey/action-trigger-validation
branch
from
f8f3ceb to
4e998bb
Compare
DanielMSchmidt
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misconfigured a test and had the sudden realization that certain validations had gotten lost - crucially, we were no longer validating that the action referenced inside a resource's ActionTriggers existed inside the config. Very early on, that happened during configload, but it was based on flawed implementation (my mistake! what is a terraform, even?) and the validation was removed when I fixed my improper handling.
I tried a few options but decided that this particular validation fit best in the configuration transformation process, as it is a matter of connecting the resource's action to the action configuration. I took some inspiration from validateImportTargets code, mostly in how I crafted the error, and in deciding to return after validating the actions if an error is encountered. I'm open to alternate suggestions!
…
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry