Skip to content

Conversation

liamcervante
Copy link
Member

This PR adds the flags for invoking actions to the plan and apply commands, and propagates them through to the plan options. For now, the plan does nothing with the new options - this will be added in a follow up PR.

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@liamcervante liamcervante added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Aug 28, 2025
@liamcervante liamcervante requested a review from a team as a code owner August 28, 2025 11:15
DanielMSchmidt
DanielMSchmidt previously approved these changes Aug 28, 2025
}

if !o.Refresh && len(o.ActionTargets) > 0 {
// TODO: Check this? Can we trigger actions without refreshing?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we said we wanted to have the option to skip refresh like we do in other commands

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add some tests for this, and enable in a follow up PR.

Base automatically changed from liamcervante/action-invoke/addrs to main August 28, 2025 12:05
@liamcervante liamcervante dismissed DanielMSchmidt’s stale review August 28, 2025 12:05

The base branch was changed.

@liamcervante liamcervante enabled auto-merge (squash) August 28, 2025 12:06
@liamcervante liamcervante merged commit e854d83 into main Aug 28, 2025
7 checks passed
@liamcervante liamcervante deleted the liamcervante/action-invoke/command branch August 28, 2025 12:11
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants