Skip to content

support sensitive values in action configuration #37481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

support sensitive values in action configuration #37481

merged 1 commit into from
Aug 25, 2025
+180 −50

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Aug 23, 2025 •
edited
Loading

This PR adds the ability to use secret values in the action configuration.

Fixes #

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@DanielMSchmidt DanielMSchmidt added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Aug 25, 2025
@DanielMSchmidt DanielMSchmidt force-pushed the TF-27774 branch 3 times, most recently from 4b315db to 6b86d03 Compare August 25, 2025 11:48
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review August 25, 2025 11:50
@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner August 25, 2025 11:50
liamcervante
liamcervante approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@liamcervante liamcervante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just question around ephemeral values - but that can be discussed / addressed in separate PR.

@DanielMSchmidt DanielMSchmidt merged commit 871d3ce into main Aug 25, 2025
11 checks passed
@DanielMSchmidt DanielMSchmidt deleted the TF-27774 branch August 25, 2025 13:00
@DanielMSchmidt DanielMSchmidt mentioned this pull request Sep 3, 2025
Merged
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liamcervante liamcervante liamcervante approved these changes

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMSchmidt @liamcervante