Skip to content

Conversation

DanielMSchmidt
Copy link
Contributor

We disabled a few tests around error handling for actions when we refactored the way actions work in #37444. This PR re-enables them albeit differently: Instead of adding context for how to proceed (undo changes, retry failing / not-yet-run actions) we show the invocation of the action. This gives the user more context. We will wait for user feedback if the next steps would be useful as well even with this context already in place. It is a bit more difficult to add this info in the current system therefore we postpone it for now until the work is more stable.

Fixes #

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@DanielMSchmidt DanielMSchmidt added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Aug 18, 2025
@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner August 18, 2025 15:29
@DanielMSchmidt DanielMSchmidt merged commit e6dfb53 into main Aug 19, 2025
11 checks passed
@DanielMSchmidt DanielMSchmidt deleted the old-failure-behaviour branch August 19, 2025 21:42
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants