actions: improve error messages and reenable error related tests #37457
+289
−158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We disabled a few tests around error handling for actions when we refactored the way actions work in #37444. This PR re-enables them albeit differently: Instead of adding context for how to proceed (undo changes, retry failing / not-yet-run actions) we show the invocation of the action. This gives the user more context. We will wait for user feedback if the next steps would be useful as well even with this context already in place. It is a bit more difficult to add this info in the current system therefore we postpone it for now until the work is more stable.
Fixes #
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry