Skip to content

actions: add number of action invocations to change summary #37400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2025
Merged

actions: add number of action invocations to change summary #37400

merged 2 commits into from
Aug 13, 2025

Conversation

DanielMSchmidt
Copy link
Contributor

Fixes #

Target Release

1.14.x

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

@DanielMSchmidt DanielMSchmidt added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Aug 5, 2025
@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner August 5, 2025 12:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch from 24a9969 to 6620dfc Compare August 5, 2025 12:37
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch 2 times, most recently from 078fcbf to 5f0f500 Compare August 5, 2025 12:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch from 5f0f500 to cba282c Compare August 5, 2025 12:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch from cba282c to baabcb1 Compare August 5, 2025 13:36
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch from baabcb1 to 572e9c1 Compare August 5, 2025 13:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

The equivalence tests will be updated. Please verify the changes here.

mildwonkey
mildwonkey reviewed Aug 5, 2025
View reviewed changes
Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but what do you think about making the output more consistent? I prefer this:

Resources: 1 added, 0 changed, 0 destroyed.
Actions: 1 invoked.

over the current:

Resources: 1 added, 0 changed, 0 destroyed.
1 Action invoked.

@DanielMSchmidt
Copy link
Contributor Author

Sounds like a good idea, I'll do that tomorrow 👍

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch from 49f969b to 360856a Compare August 6, 2025 08:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt force-pushed the add-action-invocations-to-summary branch from 360856a to 539f24e Compare August 6, 2025 08:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

The equivalence tests will be updated. Please verify the changes here.

@DanielMSchmidt DanielMSchmidt merged commit 3cf76a7 into main Aug 13, 2025
12 checks passed
@DanielMSchmidt DanielMSchmidt deleted the add-action-invocations-to-summary branch August 13, 2025 14:47
@github-actions github-actions bot mentioned this pull request Aug 13, 2025
Draft
@DanielMSchmidt DanielMSchmidt mentioned this pull request Sep 3, 2025
Merged
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mildwonkey mildwonkey mildwonkey approved these changes

Assignees
No one assigned
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielMSchmidt @mildwonkey