Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for JUnit output from 'terraform test' #36307

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Add documentation for JUnit output from 'terraform test' #36307

merged 6 commits into from
Jan 22, 2025
+91 −0

Conversation

SarahFrench
Copy link
Member

@SarahFrench SarahFrench commented Jan 10, 2025 •
edited
Loading

This PR updated docs for the -junit-xml flag and JUnit output from `terraform test, accompanying that feature leaving experimental status.

See: #36324

Target Release

1.11.x

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Changelog not needed/falls under the changelog entry for #36324

@SarahFrench SarahFrench changed the base branch from main to junit-output-as-artifact January 10, 2025 19:37
@SarahFrench SarahFrench changed the title Make junit test output ce only Add feedback showing that JUnit output of terraform test isn't compatible with remote test execution Jan 10, 2025
@SarahFrench SarahFrench changed the title Add feedback showing that JUnit output of terraform test isn't compatible with remote test execution Add user feedback showing that JUnit output of terraform test isn't compatible with remote test execution Jan 10, 2025
Base automatically changed from junit-output-as-artifact to main January 13, 2025 13:26
@SarahFrench SarahFrench force-pushed the make-junit-test-output-ce-only branch 2 times, most recently from df85b90 to 76b01cd Compare January 13, 2025 18:57
@SarahFrench SarahFrench force-pushed the make-junit-test-output-ce-only branch from 76b01cd to e954c4b Compare January 13, 2025 19:13
@SarahFrench SarahFrench mentioned this pull request Jan 13, 2025
Closed
2 tasks
@SarahFrench SarahFrench changed the title Add user feedback showing that JUnit output of terraform test isn't compatible with remote test execution Promote JUnit output 'terraform test' feature from experimental status, make incompatibility with remote test execution explicit via flag validation Jan 13, 2025
@SarahFrench SarahFrench marked this pull request as ready for review January 14, 2025 10:11
@SarahFrench SarahFrench requested review from a team as code owners January 14, 2025 10:11
@SarahFrench SarahFrench requested a review from pbortnick January 14, 2025 10:11
@SarahFrench
Copy link
Member Author

This PR will need updating if #36315 is merged first - that PR also moves the position of JUnit-related code

pbortnick
pbortnick reviewed Jan 14, 2025
View reviewed changes
Copy link

@pbortnick pbortnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks fine from web presence POV

@SarahFrench
Copy link
Member Author

SarahFrench commented Jan 15, 2025 •
edited
Loading

Thanks!

I'm going to swap this PR to being documentation-only, with the code in a separate PR. That'll allow code changes to go out in today's beta release and the docs don't need to be rushed! This will certainly dismiss existing reviews though

@SarahFrench SarahFrench changed the title Promote JUnit output 'terraform test' feature from experimental status, make incompatibility with remote test execution explicit via flag validation Add documentation for JUnit output from 'terraform test' Jan 15, 2025
@SarahFrench SarahFrench mentioned this pull request Jan 15, 2025
Merged
2 tasks
@SarahFrench SarahFrench force-pushed the make-junit-test-output-ce-only branch from 91f5478 to d8a2323 Compare January 15, 2025 11:20
@SarahFrench SarahFrench requested a review from pbortnick January 15, 2025 12:39
@pbortnick pbortnick removed their request for review January 15, 2025 17:05
radeksimko
radeksimko previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarahFrench @radeksimko
Apply suggestions from code review
5510c11 
Co-authored-by: Radek Simko <radeksimko@users.noreply.github.com>
@SarahFrench SarahFrench added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Jan 21, 2025
@SarahFrench
Copy link
Member Author

I wish accepting final nit suggestions didn't dismiss approvals 😭

@SarahFrench SarahFrench added the 1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jan 22, 2025
@SarahFrench SarahFrench merged commit 405fbf4 into main Jan 22, 2025
15 of 17 checks passed
@SarahFrench SarahFrench deleted the make-junit-test-output-ce-only branch January 22, 2025 17:06
@github-actions github-actions bot mentioned this pull request Jan 22, 2025
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pbortnick pbortnick pbortnick left review comments

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
1.11-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahFrench @radeksimko @pbortnick