Add additional validation to secret_suffix in Kubernetes backend
#35666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
alexsomesan
reviewed
Sep 4, 2024
There was a problem hiding this comment.
This looks good to me, following our conversation in Slack.
Deferring to @jrhouston for a second pair of eyes and final approval as he's more familiar with this code than I am.
jrhouston
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Thanks for adding validation for this @bschaatsbergen – I'm going to approve, but I've left you some comments proposing some cosmetic changes to the code.
jrhouston
approved these changes
Oct 3, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue with the
secret_suffixattribute in the Kubernetes backend. It adds a check to prevent suffixes from ending with a-<number>, as this conflicts with the backend’s chunking mechanism that appends numeric indices to secret names.Details on the exact underlying issue and chunking mechanism can be found here : #35641 (comment)
Fixes #35641